Vivek, Comments below ..
Paul Vivek Titarmare wrote: > I have posted a webrev for package "relaxngDatatype" which I am porting > to OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816388-relaxngDatatype/ 1. usr/src/lib/relaxngDatatype/install-sfw Delete lines ... 78 444 79 80 exit 0 2. usr/src/lib/relaxngDatatype/sunman/relaxngDatatype.3 Line .. 42 /usr/share/lib/java/relaxngDatatype-1.0.jar does it need the version number (as previous review) ? 3. usr/src/pkgdefs/SUNWrelaxngDatatype/Makefile Delete null line .. 31 DATAFILES= 4. usr/src/pkgdefs/SUNWrelaxngDatatype/depend Format of top of file (as previous review) Copyright year JDK version ? 5. usr/src/pkgdefs/SUNWrelaxngDatatype/prototype_com No line for .. d none usr/share/lib/java/javadoc ... -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
