Jason Li wrote: > Hi, > > I'm porting patchutils which is a tool collection for manipulating patch > files). > Please take some time to review. The link is as follows, > > http://cr.opensolaris.org/~jason_li/patchutils/ >
usr/src/cmd/patchutils/METADATA - ad OSR number - maybe move Comments string and combine with NAME - here is the new guide: http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines usr/src/cmd/patchutils/Makefile.sfw usr/src/cmd/patchutils/install-sfw - remove the two spaces (ie. "# " should be "# ") in CDDL header. usr/src/cmd/patchutils/install-sfw - you can reduce redundant code like this: for i in doc/*.1 do _install M ${i} ${MAN1DIR}/`basename {i}` 444 done usr/src/pkgdefs/SUNWpatchutils/Makefile - since you don't have additional dependencies you can do this in your Makefile and remove depend file include ../Makefile.com DATAFILES= depend .KEEP_STATE: Good job! Cheers, Jim
