Paul Cunningham wrote:
> Jason,
>
> Looks mainly good to me, here are a few more comments for you, see below ...
>
> Jason Li wrote:
>> Please have a look the updated webrev.
>>
>> http://cr.opensolaris.org/~jason_li/patchutils/
>
> === Start of Comments ===
>
> 1. usr/src/cmd/patchutils/Makefile.sfw
> Replace ...
> 49 bunzip2 -dc $(VER).tar.bz2 | tar xopf -
> with something like ...
> bzip2 -dc $(TARBALL) | $(GTAR) xopf --no-same-owner -
If you're going to use gtar, why use a separate bzip & pipe instead
of just:
$(GTAR) jxopf --no-same-owner $(VER).tar.bz2
or if it's clearer:
$(GTAR) xopf --bzip2 --no-same-owner $(VER).tar.bz2
--
-Alan Coopersmith- alan.coopersmith at sun.com
Sun Microsystems, Inc. - X Window System Engineering
