Jason, Looks mainly good to me, here are a few more comments for you, see below ...
Jason Li wrote: > > Please have a look the updated webrev. > > http://cr.opensolaris.org/~jason_li/patchutils/ === Start of Comments === 1. usr/src/cmd/patchutils/Makefile.sfw Replace ... 49 bunzip2 -dc $(VER).tar.bz2 | tar xopf - with something like ... bzip2 -dc $(TARBALL) | $(GTAR) xopf --no-same-owner - 2. pkg dependencies Have you checked you really have no other dependencies, other than the defaults, using the package dependency checker script? 3. usr/src/cmd/patchutils/install-sfw You could pass the VERS= info into the script from Makefile.sfw using an environment variable. === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
