Jason Li wrote: >>> Thinks for your comments. I have made the changes which you suggested. >>> Please have a look the updated webrev. >>> >>> http://cr.opensolaris.org/~jason_li/patchutils/
> I just checked the dependencies, and found the following issues. > > *** /usr/bin/editdiff (SUNWpatchutils) requires /usr/bin/bash which is > found in SUNWbash, but that is not in listed in the depend file. > *** /usr/bin/espdiff (SUNWpatchutils) requires /usr/bin/bash which is > found in SUNWbash, but that is not in listed in the depend file. > *** /usr/bin/fixcvsdiff (SUNWpatchutils) is a perl script, but uses > /usr/bin/perl instead of /usr/perl5/bin/perl as recommended by ON Perl > Style Guidelines. > *** /usr/bin/fixcvsdiff (SUNWpatchutils) requires > /usr/perl5/5.8.4/bin/perl5.8.4 which is found in SUNWperl584core, but > that is not in listed in the depend file. > *** /usr/bin/recountdiff (SUNWpatchutils) is a perl script, but uses > /usr/bin/perl instead of /usr/perl5/bin/perl as recommended by ON Perl > Style Guidelines. > *** /usr/bin/recountdiff (SUNWpatchutils) requires > /usr/perl5/5.8.4/bin/perl5.8.4 which is found in SUNWperl584core, but > that is not in listed in the depend file. > *** /usr/bin/splitdiff (SUNWpatchutils) is a perl script, but uses > /usr/bin/perl instead of /usr/perl5/bin/perl as recommended by ON Perl > Style Guidelines. > *** /usr/bin/splitdiff (SUNWpatchutils) requires > /usr/perl5/5.8.4/bin/perl5.8.4 which is found in SUNWperl584core, but > that is not in listed in the depend file. > *** /usr/bin/unwrapdiff (SUNWpatchutils) is a perl script, but uses > /usr/bin/perl instead of /usr/perl5/bin/perl as recommended by ON Perl > Style Guidelines. > *** /usr/bin/unwrapdiff (SUNWpatchutils) requires > /usr/perl5/5.8.4/bin/perl5.8.4 which is found in SUNWperl584core, but > that is not in listed in the depend file. > > So it seems that I need to add SUNWbash and SUNWperl584core into depend > file. > > But how should I do with the perl interpreter issue? Should I write a patch > file for this? Anyway I found /usr/perl5/bin/perl and > /usr/perl5/5.8.4/bin/perl > are the same. You don't need to patch for this. /usr/bin/perl is fine for FOSS code. Cheers, Jim
