Thanks Paul, please see below, Paul Cunningham ??: > Jason, > > Looks mainly good to me, here are a few more comments for you, see > below ... > > Jason Li wrote: >> >> Please have a look the updated webrev. >> >> http://cr.opensolaris.org/~jason_li/patchutils/ > > === Start of Comments === > > 1. usr/src/cmd/patchutils/Makefile.sfw > Replace ... > 49 bunzip2 -dc $(VER).tar.bz2 | tar xopf - > with something like ... > bzip2 -dc $(TARBALL) | $(GTAR) xopf --no-same-owner - In the manpage of gtar, it says that:
-o when creating, same as --old-archive; when extracting, same as --no-same-owner Also could you explain why bzip2 and gtar should be used? > > 2. pkg dependencies > Have you checked you really have no other dependencies, > other than the defaults, using the package dependency > checker script? Thanks for reminder. I just checked, and found the following issues: *** /usr/bin/editdiff (SUNWpatchutils) requires /usr/bin/bash which is found in SUNWbash, but that is not in listed in the depend file. *** /usr/bin/espdiff (SUNWpatchutils) requires /usr/bin/bash which is found in SUNWbash, but that is not in listed in the depend file. *** /usr/bin/fixcvsdiff (SUNWpatchutils) is a perl script, but uses /usr/bin/perl instead of /usr/perl5/bin/perl as recommended by ON Perl Style Guidelines. *** /usr/bin/fixcvsdiff (SUNWpatchutils) requires /usr/perl5/5.8.4/bin/perl5.8.4 which is found in SUNWperl584core, but that is not in listed in the depend file. *** /usr/bin/recountdiff (SUNWpatchutils) is a perl script, but uses /usr/bin/perl instead of /usr/perl5/bin/perl as recommended by ON Perl Style Guidelines. *** /usr/bin/recountdiff (SUNWpatchutils) requires /usr/perl5/5.8.4/bin/perl5.8.4 which is found in SUNWperl584core, but that is not in listed in the depend file. *** /usr/bin/splitdiff (SUNWpatchutils) is a perl script, but uses /usr/bin/perl instead of /usr/perl5/bin/perl as recommended by ON Perl Style Guidelines. *** /usr/bin/splitdiff (SUNWpatchutils) requires /usr/perl5/5.8.4/bin/perl5.8.4 which is found in SUNWperl584core, but that is not in listed in the depend file. *** /usr/bin/unwrapdiff (SUNWpatchutils) is a perl script, but uses /usr/bin/perl instead of /usr/perl5/bin/perl as recommended by ON Perl Style Guidelines. *** /usr/bin/unwrapdiff (SUNWpatchutils) requires /usr/perl5/5.8.4/bin/perl5.8.4 which is found in SUNWperl584core, but that is not in listed in the depend file. So it seems that I need to add SUNWbash and SUNWperl584core into depend file. But how should I do with the perl interpreter issue? Should I write a patch file for this? > > 3. usr/src/cmd/patchutils/install-sfw > You could pass the VERS= info into the script from > Makefile.sfw using an environment variable. OK, just following the example style. -Jason > > === End of Comments =====
