Daria,
Daria Mehra wrote:
> Paul Cunningham wrote:
... cut ...
>
> The rest of inline responses address Paul's review. I made most of the
> recommended changes, but had trouble with item (8), and not sure what
> was meant in (10), please see below.
>
... cut ...
>>
>> 8. usr/src/lib/libnet/install-sfw
>> Roland Mainz wrote:
>> > Please use /usr/bin/ksh93 or /usr/bin/bash for
>> > install-sfw* and add a
>> > $ set -o errexit # at the beginning and replace ".
>> > ${SRC}/tools/install.subr" with
>> > "source ${SRC}/tools/install.subr" (the idea is
>> > to catch failures in the script and abort it at
>> > that point, right now the script will just continue).
> This approach is not working for me with bash. I see librsync using this
> with ksh93 (not a shell I'm used to), but bash gives an error for "set
> -o errexit" line:
>
> /usr/bin/sh ./install-sfw
> ./install-sfw: -o: bad option(s)
>
> Also, if I use "source" instead of the dot operator to source the
> install.subr file, bash doesn't find it:
>
> /usr/bin/sh ./install-sfw
> ./install-sfw: source: not found
> ./install-sfw: _install: not found
>
> To the best of my understanding, "source" and "." are equivalent in
> bash. Do they behave differently if errexit option is set? If this
> behavior is desired, I'll rewrite the install scripts in ksh93 to make
> it work... or perhaps someone can send an example of how do it in bash.
>
> A higher-level question is where to find documented guidelines on this?
> Few packages in the consolidation are following the above, so I'm
> assuming it's a new rule. I am using these docs, and none of them
> mention this (unless I failed to follow several levels of links somewhere):
>
> http://ostest.central.sun.com/wiki/index.php/Package_Delivery_Project
> http://webtier.sfbay.sun.com/webtier/attach/ApacheTop/IntegratingIntoSFW.html
>
> http://sfwnv.sfbay/README.txt
Roland can probably to reply to this better, so I will leave that to him
Paul
