Daria, The below looks okay to me now. But I just noticed ...
In usr/src/lib/libnet/install-sfw the directory created by the 'mkdir' (lines 49-50) should be in the 'Targetdirs' file and those lines removed from here. Daria Mehra wrote: > Paul Cunningham wrote: >> This mainly looks good to me now, just a couple of more comments ... >>> 1. usr/src/pkgdefs/Makefile >>> This looks as though it needs resyncing with gate > > Resyncing was already done, I just needed to update the webrev. Done. > >> >> 2. usr/src/lib/libnet/install-sfw >>> I don't that the 'man' pages are getting the >>> sunman-stability stuff added - shouldn't those '_install' >>> lines use the '_install M ...' option to do that? > Yes, thank you, fixed that and verified that manpages contain the added > sunman-stability text. > > I believe this is now the final version of the webrev: > http://cr.opensolaris.org/~dmehra/libnet/ > > Paul, I appreciate the detailed feedback you gave me. That's okay :-) Paul -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
