Daria,

This mainly looks good to me now, just a couple of more comments ...

Paul

=== Start of Comments ====

1. usr/src/pkgdefs/Makefile
    This looks as though it needs resyncing with gate so it
   does look at though you are trying to delete other stuff.

2. usr/src/lib/libnet/install-sfw
    I don't that the 'man' pages are getting the
    sunman-stability stuff added - shouldn't those '_install'
    lines use the '_install M ...' option to do that?

=== End of Comments ======


Daria Mehra wrote:
> I made requested updates to libnet packaging files, and fixed 
> permissions issues, so the nightly build completes cleanly. The 
> finalized webrev is posted:
> 
> http://cr.opensolaris.org/~dmehra/libnet/
> 
> The only point I did not incorporate was the request from Paul 
> Cunningham (originally from Roland Mainz) for "set -e errexit" and 
> "source ${SRC}/tools/install.subr" in install-sfw* scripts. I could not 
> make this work with bash, and did not get any further input from Roland. 
> As I said:
> 
>  > If this behavior is desired, I'll rewrite the install scripts in 
> ksh93 to make it work... or perhaps someone can send an example of how 
> do it in bash.
> 
> Please advise soon whether I must make this change, since the turnaround 
> time for a nightly build is around 10 hours these days, and I am 
> targeting build 99 for integration.
> 


-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products

Reply via email to