Paul Cunningham wrote: > This mainly looks good to me now, just a couple of more comments ... >> 1. usr/src/pkgdefs/Makefile >> This looks as though it needs resyncing with gate
Resyncing was already done, I just needed to update the webrev. Done. > > 2. usr/src/lib/libnet/install-sfw >> I don't that the 'man' pages are getting the >> sunman-stability stuff added - shouldn't those '_install' >> lines use the '_install M ...' option to do that? Yes, thank you, fixed that and verified that manpages contain the added sunman-stability text. I believe this is now the final version of the webrev: http://cr.opensolaris.org/~dmehra/libnet/ Paul, I appreciate the detailed feedback you gave me. By the way, webrev segfaults when trying to produce a PDF, is this a known bug? I did not find a Bugster CR on this. Is it perhaps related to the error webrev hits when processing the tarball? "Unexpected Error occurred reading `diff -e /dev/null new/usr/src/lib/libnet/libnet-1.1.2.1.tar.gz`: $?=0, err= 1 " See my webrev stdout/stderr below. Thanks, -- daria ------------------------------- -bash-3.2$ wx webrev SCM detected: teamware File list from: wx 'active' file '/builds/dm155201/ws-libnet-sparc/wx/tmp/webrev.list' ... Done. Workspace: /builds/dm155201/ws-libnet-sparc Compare against: /ws/sfwnv-clone Output to: /builds/dm155201/ws-libnet-sparc/webrev Output Files: usr/src/lib/libnet/Makefile.sfw patch ps new usr/src/lib/libnet/install-sfw patch ps new usr/src/lib/libnet/install-sfw-64 patch ps new usr/src/lib/libnet/libnet-1.1.2.1.tar.gz patch pssed: Missing newline at end of file standard input. new usr/src/lib/libnet/libnet_link_dlpi.c.patch patch ps new usr/src/lib/libnet/makefile.am.patch patch ps new usr/src/lib/libnet/makefile.in.patch patch ps new usr/src/lib/Makefile patch cdiffs udiffs wdiffs sdiffs frames ps old new usr/src/pkgdefs/SUNWlibnet/Makefile patch ps new usr/src/pkgdefs/SUNWlibnet/copyright patch ps new usr/src/pkgdefs/SUNWlibnet/pkginfo.tmpl patch ps new usr/src/pkgdefs/SUNWlibnet/prototype_com patch ps new usr/src/pkgdefs/SUNWlibnet/prototype_i386 patch ps new usr/src/pkgdefs/SUNWlibnet/prototype_sparc patch ps new usr/src/lib/libnet/METADATA patch ps new usr/src/lib/libnet/sunman-stability patch ps new usr/src/pkgdefs/Makefile patch cdiffs udiffs wdiffs sdiffs frames ps old new Generating PDF: /opt/onbld/bin/webrev[2550]: 689237 Segmentation Fault(coredump) Done. index.html: Done. -bash-3.2$
