Hi, This mainly looks okay to me. A few comments, see below ...
Paul Sheng-qi Jiang wrote: > Please help review the inclusion of openexr-1.6.1 and ilmbase-1.0.1 into > the sfw consolidation. > http://cr.opensolaris.org/~henryj/openexr/ ==== Start of Comments ================================= 1. Has this got an ARC case? 2. usr/src/lib/openexr/*.1 Is the format of the "Copyright strings" correct in these? 3. usr/src/pkgdefs/SUNWopenexr Why is the ilmbase bit of this not in its own SUNW pkg? and then SUNWopenexr has a dependence on that. What happens when someother new integration requires only the ilmbase bits. Just a thought. 4. usr/src/lib/openexr/Makefile.sfw Under "$(ILMBASE)/config.status:" why does it also build and install ilmbase ? Shouldn't the build bit be done under 'all:'. I think the ilmbase bit needs splitting out into its Makefile. ==== End of Comments =================================== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
