Sheng-qi Jiang wrote: > Sheng-qi Jiang wrote: >> Please help review the inclusion of openexr-1.6.1 and ilmbase-1.0.1 into >> the sfw consolidation. > > please review it again, the major change was to separate openexr and > ilmbase. > > http://cr.opensolaris.org/~henryj/openexr/
Here's some comments... usr/src/lib/openexr/METADATA - Add URL to open source project page after VERSION - Update BUGTRAQ to final category usr/src/lib/openexr/exrenvmap.1 usr/src/lib/openexr/exrheader.1 usr/src/lib/openexr/exrmakepreview.1 usr/src/lib/openexr/exrmaketiled.1 usr/src/lib/openexr/exrstdattr.1 This: 25 .\" # ident "@(#)exrenvmap.1 1.1 08/05/21 SMI" should be (ie. remove " #") 25 .\" ident "@(#)exrenvmap.1 1.1 08/05/21 SMI" (my example needs a little work :) usr/src/lib/openexr/libopenexr.3lib - needs CDDL header - should only discuss "IlmImf" library now. usr/src/lib/openexr/sunman-stability This: 26 Source for openexr (including ilmbase) is available on http://opensolaris.org.\ Should be: 26 Source for openexr is available on http://opensolaris.org.\ - BTW. This file is not used so can be removed. usr/src/pkgdefs/SUNWilmbase/depend usr/src/pkgdefs/SUNWopenexr/depend 1 # 2 # Copyright 2008 Sun Microsystems, Inc. All rights reserved. 3 # Use is subject to license terms. 4 # - move after CDDL header see: http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/prototype.Makefile usr/src/lib/ilmbase/METADATA 1 PROGRAM: ilmabase - Should be "ilmbase" 3 VERSION: 1.0.0 - Should be version 1.0.1 - Add URL to open source project page after VERSION - Update BUGTRAQ to final category usr/src/lib/openexr/libilmbase.3lib (new) - need to create new man page for ilmbase library - based on usr/src/lib/openexr/libopenexr.3lib - needs CDDL header - it should discuss Half, Iex, Imath and IlmThread Libraries usr/src/lib/ilmbase/sunman-stability This: 26 Source for openexr (including ilmbase) is available on http://opensolaris.org.\ Should be: 26 Source for ilmbase is available on http://opensolaris.org.\ (ie. keep things separate) - BTW. This file is not used, so can be removed. Cheers, Jim
