Drew, This mainly looks good to me, but see comments below ...
Paul Drew Fisher wrote: > > I am working on porting the logilab-common python libraries. These > libraries are used by pylint (python lint). If I could get a few folks > to take a look at the webrev, I'd greatly appreciate it! > > webrev is at: http://cr.opensolaris.org/~drewfish/logilab-common/ 1. usr/src/Targetdirs You new bits need aligning correctly with the existing stuff (see webrev view). 2. usr/src/lib/logilab-common/Makefile.sfw Add after line 29 ... TARBALL=$(VER).tar.gz then replace '$(VER).tar.gz' with '$(TARBALL) throughout. You may want to put 'env - ' infront of your 'python' invocations so it does not pick up random environment stuff Line .. 39 cd $(VER); python setup.py build change 'python' to '$(PYTHON)' as on line 45 3. usr/src/pkgdefs/SUNWlogilab-common/copyright Do you need to add the Sun-disclaimer stuff to the top of this? You also need to add the source owner copyright lines extracted from the uncompressed files in the tarball, see example ... "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; 4. usr/src/pkgdefs/SUNWlogilab-common/prototype_com Do not install files into /usr with the write permission bit set; you probably need to run 'protofix' in your Makefile.sfw to change the attributes of the files installed with '$(PYTHON) setup.py install' and change them here. END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
