Drew, Changes looks okay to me, but below are a couple of more comments ...
NOTE: you did something strange creating your webrev as it shows the incremental changes since last time. Its easier if the webrev is generated as previously. Paul Drew Fisher wrote: > I did an incremental webrev here: (I had forgotten to do a wx redelget > before submitting my original CR so I also did that.) > > http://cr.opensolaris.org/~drewfish/logilab-common-1/ 1. usr/src/lib/logilab-common/Makefile.sfw Remove line for rule ... 39 $(VER)/build/proto: so its contents becomes the 'all:' rule. Install line ... 46 (cd $(VER); env - $(PYTHON) setup.py install --root=$(LOCALPROTO)) why didn't you install it directly into ws proto area with this; rather than doing a temporary install and then copying it into the proto area? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
