Paul, Thank you for the review!
I did an incremental webrev here: (I had forgotten to do a wx redelget before submitting my original CR so I also did that.) http://cr.opensolaris.org/~drewfish/logilab-common-1/ > > 1. usr/src/Targetdirs > You new bits need aligning correctly with the existing > stuff (see webrev view). Fixed. > > 2. usr/src/lib/logilab-common/Makefile.sfw > Add after line 29 ... > TARBALL=$(VER).tar.gz > then replace '$(VER).tar.gz' with '$(TARBALL) throughout. Fixed. > > You may want to put 'env - ' infront of your 'python' > invocations so it does not pick up random environment > stuff Added. > > Line .. > 39 cd $(VER); python setup.py build > change 'python' to '$(PYTHON)' as on line 45 Fixed. > > 3. usr/src/pkgdefs/SUNWlogilab-common/copyright > Do you need to add the Sun-disclaimer stuff to the > top of this? Fixed and added. > > You also need to add the source owner copyright lines > extracted from the uncompressed files in the tarball, see > example ... > "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; > Fixed and added. > > > 4. usr/src/pkgdefs/SUNWlogilab-common/prototype_com > Do not install files into /usr with the write permission bit > set; you probably need to run 'protofix' in your Makefile.sfw > to change the attributes of the files installed with > '$(PYTHON) setup.py install' and change them here. Fixed. All .py[c] files are 0444 now. Thank you so much for the review! -Drew
