Drew Fisher wrote:
> Paul Cunningham wrote:

>>
>> 1. usr/src/lib/logilab-common/Makefile.sfw
>>    Remove line for rule ...
>>      39 $(VER)/build/proto:
>>    so its contents becomes the 'all:' rule.

looks good.

But additionally, do you need to 'touch' $(VER)/setup.py in the
'$(VER)/setup.py:' rule to ensure the date is current.


>>    Install line ...
>>  46 (cd $(VER); env - $(PYTHON) setup.py install --root=$(LOCALPROTO))
>>    why didn't you install it directly into ws proto area with
>>    this; rather than doing a temporary install and then copying
>>    it into the proto area?
> 
> Issue #1 is a simple change; I can make that.  The reason why I have to 
> build to a local proto area before copying into the ws proto area is 
> because of the way Sun has chosen to deliver Python modules.  Python 
> defaults to using /usr/lib/python2.4/site-packages for 3rd party 
> packages/modules.  PSARC/2005/555 requested the we use 
> /usr/lib/python2.4/vendor-packages instead.  When I issue a
> 
> # python setup.py install --root=$(ROOT)
> 
> the files get installed into $(ROOT)/usr/lib/python2.4/site-packages 
> instead of vendor-packages.
> 
> This is why I need to issue a cp -R from a local proto directory.

okay

> I have another webrev ready with the change for issue #1.  It's at:
> 
> http://cr.opensolaris.org/~drewfish/logilab-common-2/

Paul
-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to