Paul Cunningham wrote: > Drew, > > Changes looks okay to me, but below are a couple of more comments ... > > NOTE: you did something strange creating your webrev as it shows the > incremental changes since last time. Its easier if the webrev is > generated as previously. > > Paul > > 1. usr/src/lib/logilab-common/Makefile.sfw > Remove line for rule ... > 39 $(VER)/build/proto: > so its contents becomes the 'all:' rule. > > Install line ... > 46 (cd $(VER); env - $(PYTHON) setup.py install --root=$(LOCALPROTO)) > why didn't you install it directly into ws proto area with > this; rather than doing a temporary install and then copying > it into the proto area? Paul,
Issue #1 is a simple change; I can make that. The reason why I have to build to a local proto area before copying into the ws proto area is because of the way Sun has chosen to deliver Python modules. Python defaults to using /usr/lib/python2.4/site-packages for 3rd party packages/modules. PSARC/2005/555 requested the we use /usr/lib/python2.4/vendor-packages instead. When I issue a # python setup.py install --root=$(ROOT) the files get installed into $(ROOT)/usr/lib/python2.4/site-packages instead of vendor-packages. This is why I need to issue a cp -R from a local proto directory. I have another webrev ready with the change for issue #1. It's at: http://cr.opensolaris.org/~drewfish/logilab-common-2/ Thank you for the review! -Drew
