Hi Bharath, The changes mainly look good. Just couple of things, In Makefile.sfw, if you have zipped the sources, you could use bzip instead of zip. In depend file of SUNWwisemanu, you may want to change the below line
P SUNWwisemanr wiseman (root) to P SUNWwisemanr Wiseman (Root) In prototype_com file of SUNWwisemanu, change SUNWwiseman to SUNWwisemanu. Regards Muktha Bharath Kumar wrote: > Hi All, > > Requesting a code review for Wiseman. > > Wiseman - is an implementation of the WS-Management specification for > the Java SE platform. > > Webrev: http://cr.opensolaris.org/~bkumarm/wiseman/ > > Please note that I am using a local copy of saaj (LSARC/2009/236) and > jaxb (LSARC/2009/237) jars for now, will point to the proto area once > they are integrated in to the sfw gate. Wiseman will not be integrated > till saaj and jaxb are integrated into sfw gate. > > The bugster subcategory creation for wiseman is in progress. Will > create placeholder bug once the subcat is created. > > Thanks > Bharath > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
