Bharath, Looks good to me, one minor comment below ..
Paul Bharath Kumar wrote: > > I have updated the webrev incorporating the changes you had suggested > including the METADATA so that it conforms to Norm's heads-up. > > Paul Cunningham wrote: >> Bharath wrote: >>>> Bharath Kumar wrote: >>>>> >>>>> Requesting a code review for Wiseman. >>>>> >>>>> Wiseman - is an implementation of the WS-Management specification >>>>> for the Java SE platform. >>>>> >>>>> Webrev: http://cr.opensolaris.org/~bkumarm/wiseman/ >>>>> >>>>> Please note that I am using a local copy of saaj (LSARC/2009/236) >>>>> and jaxb (LSARC/2009/237) jars for now, will point to the proto >>>>> area once they are integrated in to the sfw gate. Wiseman will not >>>>> be integrated till saaj and jaxb are integrated into sfw gate. >>>>> >>>>> The bugster subcategory creation for wiseman is in progress. Will >>>>> create placeholder bug once the subcat is created. >> >>>> 3. usr/src/pkgdefs/SUNWwisemanr/copyright >>>> & usr/src/pkgdefs/SUNWwisemanu/copyright You could probably combine the first two line into something like .. "Copyright 2005, 2006 Sun Microsystems, Inc." -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
