Hi Paul, I have updated the webrev incorporating the changes you had suggested including the METADATA so that it conforms to Norm's heads-up.
Thanks Bharath Paul Cunningham wrote: > Bharath, > > Bharath wrote: >> Please see comments inline. >> >> Paul Cunningham wrote: >>> >>> This mainly looks good to me, see below for a few comments ... >>> > >>> Bharath Kumar wrote: >>>> >>>> Requesting a code review for Wiseman. >>>> >>>> Wiseman - is an implementation of the WS-Management specification >>>> for the Java SE platform. >>>> >>>> Webrev: http://cr.opensolaris.org/~bkumarm/wiseman/ >>>> >>>> Please note that I am using a local copy of saaj (LSARC/2009/236) >>>> and jaxb (LSARC/2009/237) jars for now, will point to the proto >>>> area once they are integrated in to the sfw gate. Wiseman will not >>>> be integrated till saaj and jaxb are integrated into sfw gate. >>>> >>>> The bugster subcategory creation for wiseman is in progress. Will >>>> create placeholder bug once the subcat is created. >>> >>> 1. usr/src/lib/wiseman/*.jar >>> Why are these included in the webrev ? >>> >> As mentioned above, these jars are local copy of saaj and jaxb used >> for now only. However they will be removed and I will be using the >> saaj (LSARC/2009/236) and jaxb (LSARC/2009/237) that get integrated >> into sfw. >> wiseman will not be integrated till saaj and jaxb are integrated. > > I personally would prefer that they weren't in the webrev (as they > don't need to be) > >>> 2. usr/src/lib/wiseman/METADATA >>> Why doesn't the 'SRC:' link point to the downloaded >>> source tarball? >>> >> Since there is no source tarball released, I have checked out the >> sources from cvs using the release tag and created the tarball. > > okay if there really in no source-tarball > > but don't forget to update the METADATA so that it conforms to Norm's > heads-up as in http://wikis.sun.com/display/SFWNotes/METADATA > >>> 3. usr/src/pkgdefs/SUNWwisemanr/copyright >>> & usr/src/pkgdefs/SUNWwisemanu/copyright >>> Maybe you should change this a manually wrap all the >>> looooong lines. >> >>> 4. usr/src/lib/wiseman/*.? man pages >>> Maybe these should all refer to 'wiseman' on the lines ... >>> "Source for xxxx is available on http://opensolaris.org."; >>> >>> >> I will do the changes and update the webrev > > have you updated the webrev yet ? > > paul
