Bharath, This mainly looks good to me, see below for a few comments ...
Paul Bharath Kumar wrote: > > Requesting a code review for Wiseman. > > Wiseman - is an implementation of the WS-Management specification for > the Java SE platform. > > Webrev: http://cr.opensolaris.org/~bkumarm/wiseman/ > > Please note that I am using a local copy of saaj (LSARC/2009/236) and > jaxb (LSARC/2009/237) jars for now, will point to the proto area once > they are integrated in to the sfw gate. Wiseman will not be integrated > till saaj and jaxb are integrated into sfw gate. > > The bugster subcategory creation for wiseman is in progress. Will create > placeholder bug once the subcat is created. 1. usr/src/lib/wiseman/*.jar Why are these included in the webrev ? 2. usr/src/lib/wiseman/METADATA Why doesn't the 'SRC:' link point to the downloaded source tarball? 3. usr/src/pkgdefs/SUNWwisemanr/copyright & usr/src/pkgdefs/SUNWwisemanu/copyright Maybe you should change this a manually wrap all the looooong lines. 4. usr/src/lib/wiseman/*.? man pages Maybe these should all refer to 'wiseman' on the lines ... "Source for xxxx is available on http://opensolaris.org."; END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
