On Tue, Feb 10, 2009 at 11:58:03AM -0700, Jim Walker wrote:

> Danek Duvall wrote:
>> This is pretty straightforward:
>>
>>     http://cr.opensolaris.org/~dduvall/zsh-439/
>>
>
> usr/src/cmd/zsh/METADATA
> - add name field and review METADATA here:
> http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines

I've added

    NAME: Z shell
    SRC: ftp://ftp.zsh.org/pub/zsh-4.3.9.tar.bz2

> It would be good to get a consistent CDDL header format like what is
> used here in all changed files:
> http://cr.opensolaris.org/~dduvall/zsh-439/usr/src/Targetdirs.html

I'm not sure I understand this.  How are the CDDL headers different?  wx
cddlchk doesn't return any errors for files that have the CDDL.

> usr/src/cmd/zsh/install-zsh
> - change to /usr/bin/ksh93
> - add "set -o errexit"
> - change ". ${SRC}/tools/install.subr" to "source 
> ${SRC}/tools/install.subr"
> - Here's an example:
> http://cr.opensolaris.org/~jwalker/meld/usr/src/cmd/meld/install-sfw.html

Pass.  It works just fine as it is.

Thanks,
Danek

Reply via email to