Danek, See below for my comments - some of these may be duplicates but I've included them anyway ...
Paul Danek Duvall wrote: > This is pretty straightforward: > > http://cr.opensolaris.org/~dduvall/zsh-439/ 1. usr/src/cmd/zsh/Makefile.sfw Extract the VER= info from the METADATA, something like ... VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) saves having to update for the next version update Roland Mainz wrote: > Use "env - ..." and not "env ..." in the Makefiles > to make sure "configure"&&"make" only see the env > variables they should really get (and not pick-up > any random env variable) > Use either $(SHELL) or /usr/bin/bash for "configure" > calls (so we know which one is used and "configure" > doesn't pick one itself) For ' ./configure -n --prefix=...' use the predefined $(CFGPREFIX) value from Makefile.master. 2. usr/src/cmd/zsh/METADATA Missing the NAME: field, see ... http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines 3. usr/src/cmd/zsh/install-zsh The VERS= info could be passed in from the Makefile.sfw as an environment var. The version on these line ... 32 MODDIR=${PREFIX}/lib/zsh/4.3.9/zsh 33 FUNDIR=${PREFIX}/share/zsh/4.3.9/functions could also be passed in from the Makefile.sfw And I know you have already dismissed it, but .. Roland Mainz wrote: > Use /usr/bin/ksh93 or /usr/bin/bash for install-* > and add a $ set -o errexit # at the beginning and > replace ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to catch > failures in the script and abort it at that point, > right now the script will just continue) -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
