On Wed, Feb 11, 2009 at 01:41:41PM +0000, Paul Cunningham wrote:

> 1. usr/src/cmd/zsh/Makefile.sfw
>    Extract the VER= info from the METADATA, something like ...
>     VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
>    saves having to update for the next version update

Thanks.

>    For ' ./configure -n --prefix=...' use the predefined
>    $(CFGPREFIX) value from Makefile.master.

I'll use the $(CONFIGURE_OPTIONS) that Makefile.master sets, since that
gets me the man directory as well.

> 2. usr/src/cmd/zsh/METADATA
>    Missing the NAME: field, see ...
>    http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines

Yup, got it.

> 3. usr/src/cmd/zsh/install-zsh
>    The VERS= info could be passed in from the Makefile.sfw as
>    an environment var.
>
>    The version on these line ...
>      32 MODDIR=${PREFIX}/lib/zsh/4.3.9/zsh
>      33 FUNDIR=${PREFIX}/share/zsh/4.3.9/functions
>    could also be passed in from the Makefile.sfw

Done.

Would anyone have any heartburn over defining a package build variable to
use in prototype_com so I don't have to go change a bunch of "x.y.z" to
"a.b.c" each time I upgrade the package?  That should make reviewing the
changes a lot easier in future upgrades.

Thanks,
Danek

Reply via email to