Danek Duvall wrote:
>>>
>>> http://cr.opensolaris.org/~dduvall/zsh-439/
>
>> It would be good to get a consistent CDDL header format like what is
>> used here in all changed files:
>> http://cr.opensolaris.org/~dduvall/zsh-439/usr/src/Targetdirs.html
>
> I'm not sure I understand this. How are the CDDL headers different? wx
> cddlchk doesn't return any errors for files that have the CDDL.
wx cddlchk is a very terse check. It needs eyeballs ...
Take a look at the files and you will see the differences.
>> usr/src/cmd/zsh/install-zsh
>> - change to /usr/bin/ksh93
>> - add "set -o errexit"
>> - change ". ${SRC}/tools/install.subr" to "source
>> ${SRC}/tools/install.subr"
>> - Here's an example:
>> http://cr.opensolaris.org/~jwalker/meld/usr/src/cmd/meld/install-sfw.html
>
> Pass. It works just fine as it is.
I know it works as is, but the errexit fails more gracefully,
and is the standard approach we are using for install-sfw files.
Also, you should change the name to install-sfw and update
Makefile.sfw to use install-sfw.
We are trying to get things more consistent.
Cheers,
Jim
