I've split my responses up into separate emails so I can see 'the wood from the trees' :-) ....
Liu Xin wrote: ... cut ... > > Paul Cunningham : >> Liu Xin, .. cut ... >> Liu Xin wrote: >> >>> Please help review the fix of CR6689922 CR6739050 and CR6739053. Any >>> comments are welcome. Thanks. >>> >>> Webrev is at: >>> http://cr.opensolaris.org/~liuxin/ocaml_lablgtk_unison/ >>> <http://cr.opensolaris.org/%7Eliuxin/ocaml_lablgtk_unison/> ... cut .. >> 3. usr/src/cmd/ocaml/Makefile.sfw ... cut ... >> >> Use the default 'configure --prefix=..' value defined >> in Makefile.master (and any other defaults). You could >> also use the CONFIGURE_OPTIONS method, eg. >> './configure $(CONFIGURE_OPTIONS)' see other recent >> pkg integrations. >> > The ocaml built by ocaml/Makefile.sfw will generate several binary files > to install. > such as > ocamlc > ocamlcp > ocamlopt > ocamlrun > ...... > > Most of them need "ocamlrun" to run.They will be put in the proto area > as the the real SUNWocaml files > the 'configure --prefix=..' dose not only define the PATH where to > install them,but also defines where is the "ocamlrun" to run them. > For example > if use the 'configure --prefix=/usr',then build the source to generate > ocamlc ... What I meant was that you are hardcoding '-prefix /usr', but '/usr' is predefined now in Makefile.master so you should really use that for the delivered-build of ocaml. So ... you have ... ./configure -prefix /usr -mandir $(OCAML_MAN) as Makefile.master has the following defined ... CFGPREFIX= /usr CFGMAN = .... so you could have used .. ./configure -prefix $(CFGPREFIX) -mandir $(CFGMAN) I assume 'configure -prefix ..' is correct for ocaml rather than 'configure --prefix=...'. Paul -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
