Item 7 ...
Liu Xin wrote:
... cut ...
> Paul Cunningham:
>> Liu Xin wrote:
>>
>>> Please help review the fix of CR6689922 CR6739050 and CR6739053. Any
>>> comments are welcome. Thanks.
>>>
>>> Webrev is at:
>>> http://cr.opensolaris.org/~liuxin/ocaml_lablgtk_unison/
>>> <http://cr.opensolaris.org/%7Eliuxin/ocaml_lablgtk_unison/>
... cut ...
>> 7. usr/src/cmd/lablgtk/install-sfw
>> Is the 'make install' actually installing it into the
>> proto area (eg. no DESTDIR= or equivalent)?
>>
> Yes, the install path will be defined by the "configue" in the
> Makefile.sfw .
> 'make install' will use the makefile that is generated by the "configue".
But in lablgtk/Makefile.sfw you do ...
./configure --with-libdir=$(LABLGTK_PREFIX)/lib/ocaml \
--prefix=$(LABLGTK_PREFIX)
....
$(GMAKE) world
where LABLGTK_PREFIX="$(ROOT)/usr"
so when in lablgtk/install-sfw you do ...
${MAKE} INSTALL="/usr/ucb/install -c" install
isn't that going to install into $(ROOT)/usr, the proto area, and expect
to be |found in $(ROOT)/usr after 'pkgadd SUNWlablgtk'
I would have expected './configure --prefix=$(LABLGTK_PREFIX)' to be ..
./configure --prefix=/usr
or rather './configure --prefix=$(CFGPREFIX)' from Makefile.master.
Then done, in lablgtk/install-sfw, something like ..
$(GMAKE) DESTDIR=${LABLGTK_PREFIX} install
Paul
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products
