Liu,
From my *very* quick skip through this now looks okay to me if ...
1. Your ARC is happy with you delivering *.a static libraries
2. The Gatekeeper/C-Team are happy with you building ocaml twice
during the ws build.
You also might want to apply ...
Christopher Mi wrote:
> Use the method define in Makefile.master
> since you have a standard METADATA file.
>
> VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
> TARBALL =$(VER).tar.bz2
Paul
Liu Xin wrote:
> Hi,Folks,
>
> I made a few updates to the code,
> so would like another quick review.
>
>
> Hi, Paul,
>
> Thanks for your comments
> Will you please help to review the code again?
>
>
> Webrev is at:
>
> http://cr.opensolaris.org/~liuxin/ocaml_lablgtk_unison/
> <http://cr.opensolaris.org/%7Eliuxin/ocaml_lablgtk_unison/>
>
>
> all install-* files
> Modified them based on the 'Roland Mainz' comments in sfwnv-discuss:
> - added "$ set -o errexit"
> - use "/usr/bin/ksh93"
>
> usr/src/cmd/lablgtk/Makefile.sfw
> usr/src/cmd/ocaml/Makefile.sfw
> - use $(SHELL) for "configure"
> - use "env - ..." and not "env ..."
> - use the value defined in Makefile.master
>
> update all the copyright
>
> check and remove the write permission bit
>
> By the way, I have to deliver the static *.a libraries of Ocaml and Lablgtk.
> They are required when building unison or other source with ocaml and lablgtk.
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products
