Hi,Folks, I made a few updates to the code, so would like another quick review.
Hi, Paul, Thanks for your comments Will you please help to review the code again? Webrev is at: http://cr.opensolaris.org/~liuxin/ocaml_lablgtk_unison/ <http://cr.opensolaris.org/%7Eliuxin/ocaml_lablgtk_unison/> all install-* files Modified them based on the 'Roland Mainz' comments in sfwnv-discuss: - added "$ set -o errexit" - use "/usr/bin/ksh93" usr/src/cmd/lablgtk/Makefile.sfw usr/src/cmd/ocaml/Makefile.sfw - use $(SHELL) for "configure" - use "env - ..." and not "env ..." - use the value defined in Makefile.master update all the copyright check and remove the write permission bit By the way, I have to deliver the static *.a libraries of Ocaml and Lablgtk. They are required when building unison or other source with ocaml and lablgtk. Regards, Liu Xin -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20080912/c017aac0/attachment.html>
