Hi Liu Xin and Bill,
Here is my comments:
1. usr/src/cmd/lablgtk/Makefile.sfw
Line 63 is too long. Consider to use the following command
or add a patch.
sed 's/\$PWD/`pwd`/g' ...
Line 71 is too long.
As Paul suggest you can do like this,
CONFIGURE_OPTIONS += --with-libdir=$(CFGLIB)/ocaml
configure $CONFIGURE_OPTIONS
2. variable VER
You define the source code directory using the following variables:
SERVER=unison-2.27.57
VERS=2.27.57
PKGVERS=unison-${VERS}
VER=ocaml-3.10.2
VER=lablgtk-2.10.1
Please make them consistent or use the method define in Makefile.master
since you have a standard METADATA file.
VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
TARBALL =$(VER).tar.bz2
Others is OK to me.
Thanks,
Chris
Liu Xin wrote:
> Hi,Folks,
>
> I made a few updates to the code,
> so would like another quick review.
>
>
> Hi, Paul,
>
> Thanks for your comments
> Will you please help to review the code again?
>
>
> Webrev is at:
>
> http://cr.opensolaris.org/~liuxin/ocaml_lablgtk_unison/
> <http://cr.opensolaris.org/%7Eliuxin/ocaml_lablgtk_unison/>
>
>
> all install-* files
> Modified them based on the 'Roland Mainz' comments in sfwnv-discuss:
> - added "$ set -o errexit"
> - use "/usr/bin/ksh93"
>
> usr/src/cmd/lablgtk/Makefile.sfw
> usr/src/cmd/ocaml/Makefile.sfw
> - use $(SHELL) for "configure"
> - use "env - ..." and not "env ..."
> - use the value defined in Makefile.master
>
> update all the copyright
>
> check and remove the write permission bit
>
> By the way, I have to deliver the static *.a libraries of Ocaml and Lablgtk.
> They are required when building unison or other source with ocaml and lablgtk.
>
>
> Regards,
> Liu Xin
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
