See below ... Paul
shweta phabba wrote: > Thanks for suggestions given . > i have updated according to points given below . you can check the same at > http://cr.opensolaris.org/~pshweta/SQLAlchemy/ > 1. And for how to invoke this as it is library i have seen examples in > which user has to just import it in code so there is no binary which comes > with source code. > 2. For sunman stability : With tar file i didn't got any man pages. And > as it is given as optional in porting procedure i have not created the > same. > Do i have to create the same .? I think you probably do, but check with the sfw c-team to be sure. > > Paul Cunningham wrote: >>>> shweta phabba wrote: >>>>> >>>>> I have created the webrev for package sqlalchemy. please review the >>>>> code for sqlalchemy porting >>>>> Link for sqlalchemy webrev is , >>>>> http://cr.opensolaris.org/~pshweta/sqlalchemy/ >> >> == START == >> 2. usr/src/lib/Makefile >> Add your stuff alphabetically This files doesn't seem to be in the webrev anymore - it should be >> 3. usr/src/lib/sqlalchemy/METADATA Typo in the 'COMMENTS:' line - capital 'A' on 'toolkit And object' but you could have left this line blank I think. 4. usr/src/lib/sqlalchemy/Makefile.sfw There are now two 'install:' rules, lines 40-41 and 46-47 ?? >> 5. usr/src/lib/sqlalchemy/install-sfw Delete line 31 '31 #BASEDIR=${PWD}/${VER}' >> Should there be a man page for this pkg, you may need >> to create your own for it ? See above. The SCCS ident line looks wrong >> 6. usr/src/pkgdefs/Makefile >> Where are the changes to this to add SUNWsqlalchemy into the list Its still not in the webrev >> 7. usr/src/pkgdefs/SUNWsqlalchemy/Makefile The SCCS ident line still looks wrong >> 10. usr/src/pkgdefs/SUNWsqlalchemy/pkginfo >> This files shouldn't be in the webrev as its autogenerated from >> the SUNWsqlalchemy/pkginfo.tmpl file as build time this file is still in the webrev >> 11. usr/src/pkgdefs/SUNWsqlalchemy/prototype_com >> The top of the file 'CDDL' header, etc, does not conform to the >> prototypes, see guide lines in >> http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines its still wrong, delete the double-space, eg. ... # .......... becomes .. # .......... >> == END ===
