hi, Sure i will do the changes . Thanks.
Regards, Shweta Paul Cunningham wrote: > A few new minor comments below ... > > Paul > > shweta phabba wrote: >> >> As sqlalchemy 0.5.6 version is up now i have done webrev for >> sqlalchemy 0.5.6 and it is available at >> http://cr.opensolaris.org/~pshweta/sqlalchemy_0.5.6/ >> So please review the same . > >>>>>>>> shweta phabba wrote: >>>>>>>>> I have created the webrev for package sqlalchemy. please >>>>>>>>> review the code for sqlalchemy porting >>>>>>>>> Link for sqlalchemy webrev is , >>>>>>>>> http://cr.opensolaris.org/~pshweta/sqlalchemy/ > > 1. usr/src/lib/sqlalchemy/SQLAlchemy-0.5.5.tar.gz > Wrong version of tarball in webrev! > > 2. usr/src/Makefile > This hasn't changed (I think) ? > > 3. usr/src/Targetdirs > This looks as though it needs resyncing with gate/clone. > > 4. usr/src/lib/sqlalchemy/Makefile.sfw > Lines 34 and 36 - why? would it be better to .. > a) delete line 34 > b) and change ... > 36 all32: $(VER)/setup.py > to ... > all: $(VER)/setup.py > > Line 48, shouldn't the '-rm ...' be on a line on its own, eg .. > clean: > -rm -rf $(VER) >
