hi, Thanks Paul . I will do the same.
Regards, Shweta Paul Cunningham wrote: > Looks mainly okay to me, just a couple of minor comments ... > > Paul > > shweta phabba wrote: >> >> I got feedback in ARC review that i should port sqlalchemy to python >> 2.6 which before i was doing for python2.4 >> So i have updated the webrev . Please review the same . >> http://cr.opensolaris.org/~pshweta/SQLALCHEMY_PYTHON-2.6/ > > >>>>>> shweta phabba wrote: >>>>>>> I have created the webrev for package sqlalchemy. please review >>>>>>> the code for sqlalchemy porting >>>>>>> Link for sqlalchemy webrev is , >>>>>>> http://cr.opensolaris.org/~pshweta/sqlalchemy/ > > 1. usr/src/lib/sqlalchemy/Makefile.sfw > > Line 39, maybe 'python' should be $(PYTHON26) - defined in > Makefile.master > > Line 48, the 'clean' rule doesn't look right, it doesn't > seem to do anything. > > 2. Version > The current version from http://www.sqlalchemy.org now seems > to be 0.5.6
