Shweta, This looks okay to me, except for item below ...
Paul shweta phabba wrote: > > I have updated the webrev with following changes , So please have a look > at new webrev which is available at > http://cr.opensolaris.org/~pshweta/sqlalchemy0.5.6/ >> shweta phabba wrote: >>> >>> As sqlalchemy 0.5.6 version is up now i have done webrev for >>> sqlalchemy 0.5.6 and it is available at >>> http://cr.opensolaris.org/~pshweta/sqlalchemy_0.5.6/ >>> So please review the same . >> >>>>>>>>> shweta phabba wrote: >>>>>>>>>> I have created the webrev for package sqlalchemy. please >>>>>>>>>> review the code for sqlalchemy porting >>>>>>>>>> Link for sqlalchemy webrev is , >>>>>>>>>> http://cr.opensolaris.org/~pshweta/sqlalchemy/ 1. usr/src/Targetdirs & usr/src/lib/Makefile & usr/src/pkgdefs/Makefile These looks as though they need resyncing with gate/clone, so it doesn't look as though your trying to change other stuff. -- Paul Cunningham Software Engineer
