hi, I got feedback in ARC review that i should port sqlalchemy to python 2.6 which before i was doing for python2.4 So i have updated the webrev . Please review the same . http://cr.opensolaris.org/~pshweta/SQLALCHEMY_PYTHON-2.6/
Thanks. Regards, Shweta Paul Cunningham wrote: > Looks okay, but a couple of minor comments, see below ... > > Paul > > Shweta Phabba wrote: >> Thanks. Sorry for that error . I have updated now you can check the >> files at >> http://cr.opensolaris.org/~pshweta/sqlalchemy_final > >>>> shweta phabba wrote: >>>>> I have created the webrev for package sqlalchemy. please review >>>>> the code for sqlalchemy porting >>>>> Link for sqlalchemy webrev is , >>>>> http://cr.opensolaris.org/~pshweta/sqlalchemy/ > > 1. usr/src/lib/sqlalchemy/Makefile.sfw > The SCCS ident data doesn't look correct. > > Add a line-space after lines 39 and 41 just to break it up a > bit. > > Line 38, is the 'CC=$(CC)' required ? >
