This mainly looks good to me, see below for a few comments though ... Paul
UVR wrote: > UVR wrote on Sun Sep 20 2009 09:11:01 GMT-0700 (PST): >> >> I'm seeking a second round of code reviews for the 'fakeroot' package. >> A webrev is available at: >> http://cr.opensolaris.org/~uvr/fakeroot/ >> >> Change from the first round: >> . Incorporate feedback from first round reviews >> . Sync with current SFW gate >> >> My target build is coming up quickly, and I'll greatly appreciate >> all feedback. 1. usr/src/cmd/fakeroot/install-sfw & usr/src/pkgdefs/SUNWfakeroot/prototype_i386 & usr/src/pkgdefs/SUNWfakeroot/prototype_sparc do you need to deliver the 64 bit versions of fakeroot, usr/bin/<arch>/fakeroot, as well as usr/bin/fakeroot ? 2. usr/src/cmd/fakeroot/install-sfw Line 42 - what does the # do? 3. usr/src/pkgdefs/SUNWfakeroot/depend This looks like the contents of the default 'depend', if you have no other dependencies then you could delete this file and add 'DATAFILES=depend in your SUNWfakeroot/Makefile END -- Paul Cunningham Software Engineer
