1. usr/src/cmd/fakeroot/Makefile.sfw - You don't need the install_h target for a command (in usr/src/cmd).
2. usr/src/pkgdefs/SUNWfakeroot/depend - Seems to be the default depend file. If you really only need the default you can add DATAFILES=depend to the usr/src/pkgdefs/SUNWfakeroot/Makefile and delete the depend file that you are supplying. Does it have no other dependencies? I looked through the Arc case and there was mention of SUNWlibms but you seemed tot feel that this wasn't needed. 3. The Arc case mentions the 64-bit version but it didn't look like it was bought up during the review. Is there a benefit in having a 64-bit version of fakeroot? Otherwise it looks fine. Amanda UVR wrote: > UVR wrote on Sun Sep 20 2009 09:11:01 GMT-0700 (PST): >> >> I'm seeking a second round of code reviews for the 'fakeroot' package. >> A webrev is available at: >> http://cr.opensolaris.org/~uvr/fakeroot/ >> >> Change from the first round: >> . Incorporate feedback from first round reviews >> . Sync with current SFW gate >> >> My target build is coming up quickly, and I'll greatly appreciate >> all feedback. > > > My apologies to everyone who may have taken a look at the webrev > above in the past ~1.5 hours -- please RELOAD the URL. > > I found a slight problem with a few of the files, which I have > fixed and refreshed at the same location. > > -UVR. > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
