Ali Bahrami <Ali.Bahrami at Sun.COM> writes:
> I'd like to request a code review. I'm updating GNU emacs to
> version 23.1, and fixing a bug that affects the Buffers menu in the
> GTK version:
>
> 6892736 Update GNU emacs to version 23.1
> 6889305 emacs buffers menu is not updating in build 124
[...]
> The webrev can be found at:
>
> http://cr.opensolaris.org/~alib/emacs/
>
> Thank you for your time.
Great, thanks for doing this.
One annoying issue you might need to be aware of, which I found when I
built emacs 23.1 myself:
GTK+ Emacs 23.1 on Solaris 10/11 ignores all X toolkit options
http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4330
Could you please check if your build is affected as well? Perhaps it is
possible to identify the fix from CVS Emacs and apply it?
Not a review (which is hard with all the mechanical change due to version
numbers), but a couple of comments:
* One thing I found confusing in the install-sfw script is sections like
this:
SFL="usr/gnu/share"
DST="${ROOT}/usr/gnu/share"
SFL="usr/gnu/share/man"
DST="${ROOT}/usr/gnu/share/man"
SFL="usr/gnu/share/man/man1"
DST="${ROOT}/usr/gnu/share/man/man1"
_install N ${SFL}/ctags.1 ${DST}/ctags.1 444
_install N ${SFL}/etags.1 ${DST}/etags.1 444
Why set SFL and DST three times only to override the value immediately?
* I see you build emacs with --with-gif=no. Would it be possible to change
this, at least in the future? I suppose there could be legal problems
with shipping libgif, though.
* Would it be possible to replace explicit version numbers in the
prototype* files by variables? This would massively reduce the size of
the diffs in the future.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
