Hi Rainer,
Thanks for the review. Responses are inline below.
- Ali
Rainer Orth wrote:
> One annoying issue you might need to be aware of, which I found when I
> built emacs 23.1 myself:
>
> GTK+ Emacs 23.1 on Solaris 10/11 ignores all X toolkit options
> http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4330
>
> Could you please check if your build is affected as well? Perhaps it is
> possible to identify the fix from CVS Emacs and apply it?
I'll have a look. No promises, but that does sound annoying...
>
> Not a review (which is hard with all the mechanical change due to version
> numbers), but a couple of comments:
>
> * One thing I found confusing in the install-sfw script is sections like
> this:
>
> SFL="usr/gnu/share"
> DST="${ROOT}/usr/gnu/share"
> SFL="usr/gnu/share/man"
> DST="${ROOT}/usr/gnu/share/man"
> SFL="usr/gnu/share/man/man1"
> DST="${ROOT}/usr/gnu/share/man/man1"
> _install N ${SFL}/ctags.1 ${DST}/ctags.1 444
> _install N ${SFL}/etags.1 ${DST}/etags.1 444
>
> Why set SFL and DST three times only to override the value immediately?
install-sfw, the changes to Targetdirs, and the prototype files, are all
mechanically generated by a perl script I wrote to help me manage the thousands
of files in an emacs distribution. I run 'ls ls -a1FR', and then turn it into
a manifest file that I feed to that script. Here's what that part of the
manifest
looks like:
dir_sys * * usr/gnu/share
dir_bin * * usr/gnu/share/man
dir_bin * * usr/gnu/share/man/man1
file emacs * ctags.1
file emacs * etags.1
Where the columns are:
item package platform file
So the output you see is just a reflection of non-optimized script output.
Those lines have more meaning to the Targetdirs and packaging output.
Harmless, but ugly. I'll trim out the excess lines.
>
> * I see you build emacs with --with-gif=no. Would it be possible to change
> this, at least in the future? I suppose there could be legal problems
> with shipping libgif, though.
Solaris doesn't have the necessary GIF library, and providing it is outside the
scope of what I'm prepared to do. The previous emacs didn't have GIF support
either. Configure needed the explicit option this time --- I'm not sure why.
However, the moment that library appears, I'll be happy to use it. I'm not
really sure why that hasn't already happened.
>
> * Would it be possible to replace explicit version numbers in the
> prototype* files by variables? This would massively reduce the size of
> the diffs in the future.
It would, but I would have to get the SFW tools that process the packages to
expand them, and it doesn't seem worth it. I've put my faith in the fact that
the files are mechanically generated, and so anything that the GNU package
delivers will be faithfully put into the Solaris package. I'm therefore
leveraging the effort put in by the GNU emacs developers to deliver the right
files, and as such, not very concerned about the size of the package diffs.
Thanks again!
- Ali
