I was able to build everything with your changes, code changes all look good. Like Rainer I think that the install-sfw script could be simplified but that's just a nit (seeing that everything works).
So looks good to me. Amanda Ali Bahrami wrote: > I'd like to request a code review. I'm updating GNU emacs to > version 23.1, and fixing a bug that affects the Buffers menu in the > GTK version: > > 6892736 Update GNU emacs to version 23.1 > 6889305 emacs buffers menu is not updating in build 124 > > The most significant change is that the license changes from GPLv2 to > GPLv3. A new full open source review (OSR) has already been completed > for this. > > Other changes: > - There is no need for patches to the configure stuff > this time --- my previous changes were picked up by > the upstream community. > > - The upstream community is now providing some of the manpages > I had to provide last time. > > - It is possible to ship a 64-bit version of the sparc GTK > binary this time --- there was an undiagnosed bug before in > the emacs GTK code that seems to have been resolved. > > The webrev can be found at: > > http://cr.opensolaris.org/~alib/emacs/ > > Thank you for your time. > > - Ali > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
