On Tuesday, 17 October 2006 16:45, Stefan Seyfried wrote: > On Tue, Oct 17, 2006 at 02:42:12PM +0200, Rafael J. Wysocki wrote: > > On Tuesday, 17 October 2006 08:41, Stefan Seyfried wrote: > > > > I did not forget this one, but will test later today. > > > > OK > > I tested it and it works. The moon only starts blinking after "shrinking > memory" which might take some time, so i reordered it a little bit. It even > makes the patch smaller:
I don't think this ordering is correct, becuase if platform_prepare() succeeds and then swsusp_shrink_memory() fails, we should revert the changes made by platform_prepare() in the error path. -- You never change things by fighting the existing reality. R. Buckminster Fuller ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel