On Tue, Oct 17, 2006 at 09:27:57PM +0200, Rafael J. Wysocki wrote: > > I tested it and it works. The moon only starts blinking after "shrinking > > memory" which might take some time, so i reordered it a little bit. It even > > makes the patch smaller: > > I don't think this ordering is correct, becuase if platform_prepare() succeeds > and then swsusp_shrink_memory() fails, we should revert the changes made > by platform_prepare() in the error path.
Yes. Good catch. I don't have the machine with the code on it here, but just adding this: ----------------------------------- goto thaw; } + error = platform_prepare(); + if (error) + goto thaw; + /* Free memory before shutting down devices. */ if (!(error = swsusp_shrink_memory())) return 0; + + platform_finish(); thaw: thaw_processes(); enable_nonboot_cpus(); ------------------------------------ (sorry, hand-painted "patch" :-) will fix this. -- Stefan Seyfried QA / R&D Team Mobile Devices | "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out." ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel