On Fri, Jul 27, 2007 at 08:45:41PM +0200, Rafael J. Wysocki wrote: > On Friday, 27 July 2007 18:33, Stefan Seyfried wrote: > > On Fri, Jul 27, 2007 at 05:18:45PM +0200, Rafael J. Wysocki wrote: > > > > > > (yes, i think i know what it does; writing 1 into the state of the > > > > framebuffer device just disables any drawing - and thus any access > > > > of possibly not really initialized hardware before running vbe_post > > > > etc...) > > > > At least it seemed to do no harm in my (limited) tests. > > > > > > I think it can go if > > > (1) it doesn't break any setups that currently work > > > > We will know after the next openSUSE alpha release, where i will have > > unleashed that patch onto the unexpecting guinea pigs^W^WopenSUSE users ;-) > > If i don't get a wave of bugreports, than i'll assume that it is safe. > > > > Theoretically we could "protect" it by another quirk-flag, but i'd rather > > try to avoid that. > > Agreed. > > > I will also go through the kernel code and check if anything can go wrong. > > Yes, please do that if you can.
I did try to go through the kernel code, but i'd not put my hand into the fire and guarantee that it does not do anything stupid :-) Some drivers (radeonfb and i810fb for example) are already doing this in their suspend method and it seems to work. That said, it should long-term be fixed in the kernel properly, but if we can prove from userspace that it helps some machines, then we know that it is worth the trouble. > > Echoing "1" into the state file simply makes the text console "freeze" (but > > apparently it is still doing stuff in the background, you can still output > > text etc, you just won't see it). Echoing "0" will make it paint the current > > screen contents. At least that was what happened in my experiments. > > > > > (2) it fixes at least one box that currently doesn't work > > > > Yes, the user in the bugreport is a happy camper now :-) (he does not have > > the s2ram code right now, but uses the script equivalent, but unless i have > > put a bug into the C code, it should be equivalent). > > Can you ask the user to test s2ram with your patch, please? yes, i will do that once i have built and pushed a package. -- Stefan Seyfried QA / R&D Team Mobile Devices | "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out." This footer brought to you by insane German lawmakers: SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel
