hi aaron will it convert the tab into four spaces if I run the strip utility?
thanks kasun On Fri, Apr 16, 2010 at 10:20 PM, Aaron S. Meurer <asmeu...@gmail.com>wrote: > Sorry, it still doesn't work for me. The problem is that you have > abstractalgebra nested twice. Also, I think you might need to add something > to the main sympy/__init__.py (assuming we want this imported with from > sympy import *; do we?). > > The ./bin/strip_whitespace utility will help with the other failure. Setup > your text editor to use 4 spaces instead of tabs: > > > ________________________________________________________________________________ > > > /users/aaronmeurer/documents/python/sympy/sympy/sympy/abstractalgebra/abstractalgebra/test_primefield.py > File > "/users/aaronmeurer/documents/python/sympy/sympy/sympy/abstractalgebra/abstractalgebra/test_primefield.py", > line 1, in <module> > from sympy.abstractalgebra.finitefield import PrimeField > ImportError: No module named abstractalgebra.finitefield > > > ________________________________________________________________________________ > __ > sympy/utilities/tests/test_code_quality.py:test_whitespace_and_exceptions > ___ > File > "/users/aaronmeurer/documents/python/sympy/sympy/sympy/utilities/tests/test_code_quality.py", > line 97, in test_whitespace_and_exceptions > check_directory_tree(SYMPY_PATH, test, exclude) > File > "/users/aaronmeurer/documents/python/sympy/sympy/sympy/utilities/tests/test_code_quality.py", > line 58, in check_directory_tree > file_check(fname) > File > "/users/aaronmeurer/documents/python/sympy/sympy/sympy/utilities/tests/test_code_quality.py", > line 82, in test > assert False, message_tabs % (fname, idx+1) > AssertionError: File contains tabs instead of spaces: > /users/aaronmeurer/documents/python/sympy/sympy/sympy/abstractalgebra/abstractalgebra/finitefield.py, > line 11. > > Aaron Meurer > On Apr 15, 2010, at 5:49 PM, Kasun Samarasinghe wrote: > > hi aaron, > > I managed to make it passed test, please give me the comment. attached the > patch with this > > thank you > kasun > > On Fri, Apr 16, 2010 at 12:31 AM, Ronan Lamy <ronan.l...@gmail.com> wrote: > >> Le jeudi 15 avril 2010 à 13:46 -0600, Aaron S. Meurer a écrit : >> > - I think PrimeField should subclass from Expr or Basic (though I could >> be wrong on this one). >> > >> No, it should not. Instances of PrimeField are equivalent to classes >> like Integer or Rational. I think sympy is not quite ready for this >> yet. >> In the current model, PrimeField "should" be a metaclass and can only >> subclass BasicType (which is empty). It is its instances which "should" >> be subclasses of Basic. And yes, this would probably be very messy. >> >> So, it is reasonable to implement finite fields outside the main >> hierarchy (note that polynomials are also outside the main hierarchy, >> ultimately for the same reason). When sympy grows ways to manipulate >> types, they can be brought back into the fold. >> >> > - How is this different from the GF >> > implementation in polys? Should this rather just be providing a user >> > interface to that? >> >> I think it's the opposite: polys should interface with the generic >> implementation. Ultimately, the implementations should be merged, but >> the code should move out of polys and into the new module. >> >> Ronan >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To post to this group, send email to sy...@googlegroups.com. >> To unsubscribe from this group, send email to >> sympy+unsubscr...@googlegroups.com <sympy%2bunsubscr...@googlegroups.com> >> . >> For more options, visit this group at >> http://groups.google.com/group/sympy?hl=en. >> >> > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to sy...@googlegroups.com. > To unsubscribe from this group, send email to > sympy+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > <0001-Finite-Field-Implementation-Prime-Field-Only.patch> > > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to sy...@googlegroups.com. > To unsubscribe from this group, send email to > sympy+unsubscr...@googlegroups.com <sympy%2bunsubscr...@googlegroups.com>. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sy...@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
