Needs Decision is good to keep, but I would drop Needs Work. If the PR is open and has comments that haven't been addressed it needs work.
If someone has made changes and they want to indicate that it'res ready for review again they can use the Needs Review -- or perhaps because of permission settings they can't? (But then anyone with permissions can reset the flag to indicate that changes were made and someone should review it again.) Passed Review is good if one is not going to commit the PR but feels that all issues have been addressed. On Friday, April 17, 2015 at 2:32:17 PM UTC-5, James Crist wrote: > > That's at least a little nicer. How about the following for status tags: > > - Needs Decision : community hasn't decided how to handle this > - Needs Work : PR needs work to meet standards > - Needs Review : PR needs review by someone before being merged > > Seems to cover all the bases, but I'm still not certain how useful the > second 2 are (needs decision *is* useful). > > Mainly, all open PRs are assumed to need review, we shouldn't need to have > to label them to note that. And who is `Needs Work` directed to? If it's to > notify reviewers, the tag will still there once it's updated by the > submitter, so reviewers would have to open the PR to know the status either > way (and as Joachim pointed out, only core devs can change labels). And if > it's to notify the submitter, simply commenting what changes need to be > made is more informative than tagging. > > Again, if people feel the tags would be useful, we can keep them. I've > made my case, but could go either way on this. > > - Jim > > On Friday, April 17, 2015 at 2:13:06 PM UTC-5, Sudhanshu Mishra wrote: >> >> Hi, >> >> >>> `Needs better patch`: could be useful to indicate PR status to devs, but >>> mostly I feel that it comes off as rude to the person making the PR. I'd >>> like to remove it unless someone makes a strong argument to the contrary. >> >> >> Perhaps, we can reword it. How about "Needs changes" or "Waiting for >> changes"? >> >> Sudhanshu Mishra >> >> >> On Sat, Apr 18, 2015 at 12:35 AM, James Crist <cris...@umn.edu> wrote: >> >>> On Friday, April 17, 2015 at 1:34:55 PM UTC-5, Joachim Durchholz wrote: >>> >>>> > - Help labeling. >>>> >>>> I haven't found a way to enable tagging for people that do not have >>>> full >>>> write access to the repository. I suspect GitHub does not offer any. >>>> This is also the reason why tagging does not happen very much. >>>> >>> >>> Hmmm, you're right... >>> <https://help.github.com/articles/permission-levels-for-an-organization-repository/> >>> >>> It would be nice to allow the general public to tag issues, but I could >>> also see an argument against that due to "potential vandalism". In general, >>> I'd trust people not to mess with things, but can also see why it is the >>> way it is. Once we get through the huge backlog, having the core team tag >>> issues as they come in should be a lot more manageable. >>> >>> I have another label question: >>> >>> - `Needs better patch`: could be useful to indicate PR status to devs, >>> but mostly I feel that it comes off as rude to the person making the PR. >>> I'd like to remove it unless someone makes a strong argument to the >>> contrary. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "sympy" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to sympy+un...@googlegroups.com. >>> To post to this group, send email to sy...@googlegroups.com. >>> Visit this group at http://groups.google.com/group/sympy. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/sympy/7ed5e065-3b3e-4210-9e1a-520b8dee133b%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/sympy/7ed5e065-3b3e-4210-9e1a-520b8dee133b%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group, send email to sympy@googlegroups.com. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/a6a5174c-bb97-4339-90cf-5589cb7d96f5%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
