On Thu, Jan 19, 2012 at 05:09:25PM +0100, Michael Meskes wrote: > On Thu, Jan 19, 2012 at 12:30:15PM +0100, Otto Moerbeek wrote: > > I looked through some of the diffs and noted your are introducing a > > race in calendar_fifo.diff. Why are you changing this code? > > Because the old code blocks if a named pipe is used as a calendar file, a bug > report is here: > > http://bugs.launchpad.net/ubuntu/+source/bsdmainutils/+bug/357055 > > Michael > -- > Michael Meskes > Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) > Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org > Jabber: michael.meskes at googlemail dot com > VfL Borussia! ForC'a BarC'a! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
Introducing a race is never the right solution, imo. By the way, your fix does not catch an included file being a fifo either. So while introducing a race, it actually does not fix the problem. -Otto