Hi, If I get time over the weekend I'll look in to this in more detail, but just going by what you've put here...
On 17 August 2013 03:41, J Raynor <jxray...@gmail.com> wrote: > In order to allow things like #S and #P in the filename I had to alter > status_replace(). That function required a non-NULL client variable, > which won't always be available when setting the filename. I altered > it so that it will accept a NULL client. If client is non-NULL, it'll > behave as before. With a NULL, it'll use s, wl, and wp to replace > what it can. Why are you using status_replace() for this? format_expand() and using a struct format_tree * makes much more sense here. What has status_replace() got to do with expanding file names? > I also added a function to cmd-string.c called > cmd_string_expand_path(). This expands a tilde or $var in the > filename. While cmd_string_parse() can do this, it leads to odd > quoting needs in conjunction with the status formatting. If you enter > ~/file-#P (no quotes), then the #P gets chopped off because it's > assumed to start a comment. If you enter "~/file-#P" then > cmd_string_parse() won't expand the tilde. You'd have to get around > it by doing ~/file-"#P". That doesn't sound right to me, and from what little testing I've done here I can't reproduce that. But I certainly don't like the idea of another function which is "similar" to cmd_string_parse(). -- Thomas Adam ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
