2011/7/9 Márton Miklós:

in the future, please attach patches to your e-mail instead of posting
random URLs

> I have generated jtag files for the Freescale MPC8347 and the MPC8313(e)
> from the Freescale provided BSDLs:
> http://dl.dropbox.com/u/4295670/freescale_devices.patch

in general, i think we're trying to get away from generated files from
BSDLs.  but i'm not sure if we support sourcing the BSDL file directly
when you do "detect".  if no one else cares, i'll merge this.

> My board has an Spansion S29LV032-04 flash with 16 bit wide data bus.
> I am using my MPC8347 based board with the mpc837x bus with these arguments:
> initbus mpc837x MUX WIDTH=16
>
> By default the flash is detected by the amd.c flash driver which did not
> suppports the unlock bypass programming mode.
> The amd_flash.c supports it, but it cannot detect it, because it's
> detection method is called after the amd.c detection.
> And at the other hand it supports only 8 bit wide data bus..
>
> So I have decided to patch the amd.c:
> http://dl.dropbox.com/u/4295670/bypass%2Bmux.patch
>
> My board uses a latch to latching the addresses from the common
> address/data bus. This causes 2 BSR shifts in every write operation.
> I have added a variable to store the last write address, to eliminate
> the latching of the addresses when it not neccessary (Two consecutive
> write cycle to the same address).
> The address of the unlock bypass program sequence is don't care, so if I
> use the address to be programmed in the first command so I spare the
> half of the BSR shifts.

you lost me ... are you making changes that are specific to your
board, or are you making general improvements that should work for
everyone ?

> --- src/flash/amd.c (revision 1966)
> +++ src/flash/amd.c (working copy)
>
> +int bypass_supported = 0;

global variables are not acceptable.  you can initialize multiple
buses simultaneously and this global variable would break that.

> +    urj_log (URJ_LOG_LEVEL_DETAIL,
> +             "\namd_flash_program_bypass 0x%08lX, count 0x%08X\n",

dont put newlines at the start of log messages

> +        offset ++;
> +        count --;

no space between the variable and the operator
-mike

------------------------------------------------------------------------------
Storage Efficiency Calculator
This modeling tool is based on patent-pending intellectual property that
has been used successfully in hundreds of IBM storage optimization engage-
ments, worldwide.  Store less, Store more with what you own, Move data to 
the right place. Try It Now! http://www.accelacomm.com/jaw/sfnl/114/51427378/
_______________________________________________
UrJTAG-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/urjtag-development

Reply via email to