2011/7/18 Márton Miklós:
>> in the future, please attach patches to your e-mail instead of posting
>> random URLs
>
> Sorry, but last time when I did it my mail was rejected due the large
> attachment.

both patches you posted were less than 100KiB

> The bypass flash write method should work for everyone who is using these
> flashes.
>
> To understood the latch patch better I attach the related part of my
> schematic.
> The SOC has a 64 bit wide port which is used as address, and data bus too.
> At the beginning of a bus-cycle it outputs the address to this bus while
> LALE is active, then turn off the latch, and then outputs the data.
> This takes 3 BSR shift. If the address did not changes between two cycle the
> latching is unneccessary for everyone who is using muxed bus.

ok, i think the issue is that you squashed two changes into one patch.
 please split them out into independent patches so things will be
clear.

>>> >  --- src/flash/amd.c (revision 1966)
>>> >  +++ src/flash/amd.c (working copy)
>>> >
>>> >  +int bypass_supported = 0;
>>
>> global variables are not acceptable.  you can initialize multiple
>> buses simultaneously and this global variable would break that.
>
> What would you recommend to share data between the flash_printinfo and the
> other flash functions?

seems like you want to extend URJ_FLASH_CFI_ARRAY in src/flash/flash.h
-mike

------------------------------------------------------------------------------
Storage Efficiency Calculator
This modeling tool is based on patent-pending intellectual property that
has been used successfully in hundreds of IBM storage optimization engage-
ments, worldwide.  Store less, Store more with what you own, Move data to 
the right place. Try It Now! http://www.accelacomm.com/jaw/sfnl/114/51427378/
_______________________________________________
UrJTAG-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/urjtag-development

Reply via email to