Johan Compagner wrote:
thats better. I think that throw exceptions on missing resources shouldn't happen in deployment mode anyway i think there is no much use for it a good log statement in the server log should be enough.i dont find it very dangerous that it shows the body IF it has a body because that you see it on your page you could see [THIS SHOULD BE A KEY] which is very easy to spot. But also the default text which is also fine. (except ofcourse if you think it comes from he db and you change something there and you don't see it, but then you change something or update something and then it should be able to look it up) johan
I definitely agree that in production mode it should not throw an exception for missing message resources.
I don't like it if it shows the default body in development mode though. Either you have to type "[THIS SHOULD BE A KEY]" all the time, or you have to make an empty body, in both cases ruining your preview.
If backwards compatiblity is necessary, why not just make it an option via the settings to turn off the exception throwing and revert to the body replacement?
I would hate it if throwing the exceptions option is lost as soon as you fill in a body in the wicket:message tag... :-( Personally I think it would really help to have exceptions because they are hard to miss and scanning huge html pages for [MISSING KEY] is error prone too.
Regards, Sebastiaan
smime.p7s
Description: S/MIME Cryptographic Signature
